types: widgets: Add URL Video widget #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickelectric
requested review from
Williangalvani,
joaoantoniocardoso and
rafaellehmkuhl
src/components/widgets/Video.vue
Outdated
| ></v-text-field> | ||
| <div> | ||
| <span class="text-xs font-semibold leading-3 text-slate-600">Fit style</span> | ||
| <Dropdown v-model="widget.options.fitStyle" :options="['cover', 'fill', 'contain']" class="max-w-[144px]" /> |
There was a problem hiding this comment.
Suggested change
| <Dropdown v-model="widget.options.fitStyle" :options="['cover', 'fill', 'contain']" class="max-w-[144px]" /> | |
| <Dropdown v-model="widget.options.fitStyle" :options="['cover', 'fill', 'contain']" variant="outlined" class="max-w-[144px]" /> |
joaoantoniocardoso
approved these changes
Oct 16, 2023
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
patrickelectric
force-pushed
the
add-video-widget
branch
from
290d4ff to
6b6d920
Compare
Signed-off-by: Patrick José Pereira <[email protected]>
patrickelectric
force-pushed
the
add-video-widget
branch
from
6b6d920 to
9bb29dc
Compare
|
I would ask on the next PRs that we follow the current pattern of one commit per logical change. |
ES-Alexander
changed the title
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Nov 23, 2023
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Nov 23, 2023
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Nov 23, 2023
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Nov 23, 2023
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Nov 23, 2023
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Nov 24, 2023
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Nov 24, 2023
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Nov 24, 2023
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Nov 24, 2023
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Nov 24, 2023
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Nov 24, 2023
ES-Alexander
added a commit
to bluerobotics/ardusub-zola
that referenced
this pull request
Nov 24, 2023
ES-Alexander
added a commit
to bluerobotics/ardusub-zola
that referenced
this pull request
Nov 24, 2023
ES-Alexander
added a commit
to bluerobotics/ardusub-zola
that referenced
this pull request
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be tested with:
http://commondatastorage.googleapis.com/gtv-videos-bucket/sample/BigBuckBunny.mp4
Fix #513